Skip to content

Conversation

@linux-riscv-bot
Copy link

PR for series 1029060 applied to workflow__riscv__fixes

Name: RISC-V: Add PARAVIRT_SPINLOCKS support
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1029060
Version: 3

Add the files functions needed to support the SBI PVLOCK (paravirt
qspinlock kick_cpu) extension. Implement kvm_sbi_ext_pvlock_kick_-
cpu(), and we only need to call the kvm_vcpu_kick() and bring
target_vcpu from the halt state.

Reviewed-by: Leonardo Bras <[email protected]>
Signed-off-by: Guo Ren (Alibaba DAMO Academy) <[email protected]>
Signed-off-by: Linux RISC-V bot <[email protected]>
Add an unfair qspinlock virtualization-friendly frontend, by halting the
virtual CPU rather than spinning.

Using static_call to switch between:
  native_queued_spin_lock_slowpath()    __pv_queued_spin_lock_slowpath()
  native_queued_spin_unlock()           __pv_queued_spin_unlock()

Add the pv_wait & pv_kick implementations.

Reviewed-by: Leonardo Bras <[email protected]>
Signed-off-by: Guo Ren (Alibaba DAMO Academy) <[email protected]>
Signed-off-by: Linux RISC-V bot <[email protected]>
Add trace point for pv_kick&wait, here is the output:

ls /sys/kernel/debug/tracing/events/paravirt/
 enable   filter   pv_kick  pv_wait

cat /sys/kernel/debug/tracing/trace
 entries-in-buffer/entries-written: 33927/33927   #P:12

                                _-----=> irqs-off/BH-disabled
                               / _----=> need-resched
                              | / _---=> hardirq/softirq
                              || / _--=> preempt-depth
                              ||| / _-=> migrate-disable
                              |||| /     delay
           TASK-PID     CPU#  |||||  TIMESTAMP  FUNCTION
              | |         |   |||||     |         |
             sh-100     [001] d..2.    28.312294: pv_wait: cpu 1 out of wfi
         <idle>-0       [000] d.h4.    28.322030: pv_kick: cpu 0 kick target cpu 1
             sh-100     [001] d..2.    30.982631: pv_wait: cpu 1 out of wfi
         <idle>-0       [000] d.h4.    30.993289: pv_kick: cpu 0 kick target cpu 1
             sh-100     [002] d..2.    44.987573: pv_wait: cpu 2 out of wfi
         <idle>-0       [000] d.h4.    44.989000: pv_kick: cpu 0 kick target cpu 2
         <idle>-0       [003] d.s3.    51.593978: pv_kick: cpu 3 kick target cpu 4
      rcu_sched-15      [004] d..2.    51.595192: pv_wait: cpu 4 out of wfi
lock_torture_wr-115     [004] ...2.    52.656482: pv_kick: cpu 4 kick target cpu 2
lock_torture_wr-113     [002] d..2.    52.659146: pv_wait: cpu 2 out of wfi
lock_torture_wr-114     [008] d..2.    52.659507: pv_wait: cpu 8 out of wfi
lock_torture_wr-114     [008] d..2.    52.663503: pv_wait: cpu 8 out of wfi
lock_torture_wr-113     [002] ...2.    52.666128: pv_kick: cpu 2 kick target cpu 8
lock_torture_wr-114     [008] d..2.    52.667261: pv_wait: cpu 8 out of wfi
lock_torture_wr-114     [009] .n.2.    53.141515: pv_kick: cpu 9 kick target cpu 11
lock_torture_wr-113     [002] d..2.    53.143339: pv_wait: cpu 2 out of wfi
lock_torture_wr-116     [007] d..2.    53.143412: pv_wait: cpu 7 out of wfi
lock_torture_wr-118     [000] d..2.    53.143457: pv_wait: cpu 0 out of wfi
lock_torture_wr-115     [008] d..2.    53.143481: pv_wait: cpu 8 out of wfi
lock_torture_wr-117     [011] d..2.    53.143522: pv_wait: cpu 11 out of wfi
lock_torture_wr-117     [011] ...2.    53.143987: pv_kick: cpu 11 kick target cpu 8
lock_torture_wr-115     [008] ...2.    53.144269: pv_kick: cpu 8 kick target cpu 7

Reviewed-by: Leonardo Bras <[email protected]>
Signed-off-by: Guo Ren (Alibaba DAMO Academy) <[email protected]>
Signed-off-by: Linux RISC-V bot <[email protected]>
The VM guests should fall back to a Test-and-Set spinlock when
PARAVIRT_SPINLOCKS disabled, because fair locks have horrible lock
'holder' preemption issues. The virt_spin_lock_key would shortcut for
the queued_spin_lock_- slowpath() function that allow virt_spin_lock
to hijack it. ref: 43b3f02 ("locking/qspinlock/x86: Fix
performance regression under unaccelerated VMs").

Add a static key controlling whether virt_spin_lock() should be
called or not. Add nopvspin support as x86.

Signed-off-by: Guo Ren (Alibaba DAMO Academy) <[email protected]>
Signed-off-by: Linux RISC-V bot <[email protected]>
@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 112.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1198.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1663.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.54 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#99: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 105 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 15eef8e23cb2 ("RISC-V: paravirt: Add pvqspinlock KVM backend") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 105 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.45 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
kdoc
Desc: Detects for kdoc errors
Duration: 0.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,V3,1/4] RISC-V: paravirt: Add pvqspinlock KVM backend"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 111.08 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 2364.46 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 3009.49 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.37 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.80 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
new file mode 100644

CHECK: Prefer using the BIT macro
#85: FILE: arch/riscv/include/asm/qspinlock.h:15:
+#define SPIN_THRESHOLD		(1 << 15)

WARNING: void function return statements are not generally useful
#172: FILE: arch/riscv/kernel/qspinlock_paravirt.c:17:
+	return;
+}

WARNING: memory barrier without comment
#192: FILE: arch/riscv/kernel/qspinlock_paravirt.c:37:
+	smp_store_release(&lock->locked, 0);

total: 0 errors, 3 warnings, 1 checks, 172 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit d3d80d6ed7e6 ("RISC-V: paravirt: Add pvqspinlock frontend") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 3 warnings, 1 checks, 172 lines checked
CHECK: Prefer using the BIT macro
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: memory barrier without comment
WARNING: void function return statements are not generally useful


@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.18 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.69 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
kdoc
Desc: Detects for kdoc errors
Duration: 0.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,V3,2/4] RISC-V: paravirt: Add pvqspinlock frontend"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 110.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1170.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1630.15 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.45 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.07 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#83: 
new file mode 100644

WARNING: Improper SPDX comment style for 'arch/riscv/kernel/trace_events_filter_paravirt.h', please use '/*' instead
#88: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:1:
+// SPDX-License-Identifier: GPL-2.0-only

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#88: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:1:
+// SPDX-License-Identifier: GPL-2.0-only

CHECK: Alignment should match open parenthesis
#103: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:16:
+TRACE_EVENT(pv_kick,
+	TP_PROTO(int cpu, int target),

CHECK: Lines should not end with a '('
#106: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:19:
+	TP_STRUCT__entry(

CHECK: Lines should not end with a '('
#111: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:24:
+	TP_fast_assign(

CHECK: Alignment should match open parenthesis
#117: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:30:
+	TP_printk("cpu %d pv_kick target cpu %d",
+		__entry->cpu,

CHECK: Alignment should match open parenthesis
#123: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:36:
+TRACE_EVENT(pv_wait,
+	TP_PROTO(int cpu),

CHECK: Lines should not end with a '('
#126: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:39:
+	TP_STRUCT__entry(

CHECK: Lines should not end with a '('
#130: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:43:
+	TP_fast_assign(

CHECK: Alignment should match open parenthesis
#135: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:48:
+	TP_printk("cpu %d out of wfi",
+		__entry->cpu

CHECK: spaces preferred around that '/' (ctx:VxV)
#143: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:56:
+#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/
                              ^

CHECK: spaces preferred around that '/' (ctx:VxV)
#143: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:56:
+#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/
                                 ^

CHECK: spaces preferred around that '/' (ctx:VxV)
#143: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:56:
+#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/
                                    ^

CHECK: spaces preferred around that '/' (ctx:VxV)
#143: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:56:
+#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/
                                         ^

CHECK: spaces preferred around that '/' (ctx:VxV)
#143: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:56:
+#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/
                                               ^

CHECK: space preferred before that '/' (ctx:VxE)
#143: FILE: arch/riscv/kernel/trace_events_filter_paravirt.h:56:
+#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/
                                                      ^

total: 0 errors, 3 warnings, 14 checks, 81 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 424bbd2ee77f ("RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 3 warnings, 14 checks, 81 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Lines should not end with a '('
CHECK: space preferred before that '/' (ctx:VxE)
CHECK: spaces preferred around that '/' (ctx:VxV)
WARNING: Improper SPDX comment style for 'arch/riscv/kernel/trace_events_filter_paravirt.h', please use '/*' instead
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
kdoc
Desc: Detects for kdoc errors
Duration: 0.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,V3,3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 110.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 2359.38 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 3008.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.51 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.61 seconds
Result: WARNING
Output:

CHECK: Consider using #include <linux/jump_label.h> instead of <asm/jump_label.h>
#55: FILE: arch/riscv/include/asm/qspinlock.h:36:
+#include <asm/jump_label.h>

total: 0 errors, 0 warnings, 1 checks, 63 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 27c281092363 ("RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 1 checks, 63 lines checked
CHECK: Consider using #include <linux/jump_label.h> instead of <asm/jump_label.h>


@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
kdoc
Desc: Detects for kdoc errors
Duration: 1.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[RFC,V3,4/4] RISC-V: paravirt: Support nopvspin to disable PARAVIRT_SPINLOCKS"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants